Skip to content

feat: support for the apac region #200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 22, 2024
Merged

feat: support for the apac region #200

merged 2 commits into from
Oct 22, 2024

Conversation

@moritzraho
Copy link
Member

@moritzraho moritzraho commented Oct 22, 2024 •
edited
Loading

Description

Add support to the library for the newly available APAC region.

Also a tiny fix: Stage supports amer only, so throw if region != amer

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link

codecov bot commented Oct 22, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (d9d930c) to head (f39e624).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff            @@
##              main      #200   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            6         6           
  Lines          272       277    +5     
  Branches        47        49    +2     
=========================================
+ Hits           272       277    +5

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@amulyakashyap09
Copy link
Contributor

amulyakashyap09 commented Oct 22, 2024

LGTM! Just Update your Branch to resolve conflict.

@moritzraho moritzraho merged commit dbd90d1 into main Oct 22, 2024
8 checks passed
@moritzraho moritzraho deleted the feat/apac-support branch October 22, 2024 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@amulyakashyap09 amulyakashyap09 amulyakashyap09 approved these changes

@MichaelGoberling MichaelGoberling MichaelGoberling approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@moritzraho @amulyakashyap09 @MichaelGoberling